Issue 13004017: More preparation for removal of dart:scalarlist

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13004017: More preparation for removal of dart:scalarlist (Closed)

Created:
7 years, 9 months ago by siva

Modified:
7 years, 9 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

More preparation for removal of dart:scalarlist - remove the intrinsification of scalarlist functions - changed class Ids to TypedData class Ids Committed: https://code.google.com/p/dart/source/detail?r=20595

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+33 lines, -510 lines)			Patch
M	runtime/vm/flow_graph_builder.cc	View	4 chunks	+25 lines, -25 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler.cc	View	2 chunks	+0 lines, -44 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	4 chunks	+8 lines, -8 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	3 chunks	+0 lines, -21 lines	0 comments	Download
M	runtime/vm/intrinsifier.h	View	2 chunks	+0 lines, -30 lines	0 comments	Download
M	runtime/vm/intrinsifier.cc	View	2 chunks	+0 lines, -6 lines	0 comments	Download
M	runtime/vm/intrinsifier_arm.cc	View	1 chunk	+0 lines, -125 lines	0 comments	Download
M	runtime/vm/intrinsifier_ia32.cc	View	2 chunks	+0 lines, -44 lines	0 comments	Download
M	runtime/vm/intrinsifier_mips.cc	View	1 chunk	+0 lines, -125 lines	0 comments	Download
M	runtime/vm/intrinsifier_x64.cc	View	2 chunks	+0 lines, -82 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

srdjan

LGTM after verifying that no performance losses are introduced

7 years, 9 months ago (2013-03-27 20:43:44 UTC) #2

siva

uploaded the patchset over to golem (asiva-remove-scalarlist)

7 years, 9 months ago (2013-03-27 23:10:45 UTC) #3

siva

7 years, 9 months ago (2013-03-27 23:15:33 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r20595 (presubmit successful).

Expand Messages | Collapse Messages