Issue 1299653003: Migrate LongJumpScope to Thread.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1299653003: Migrate LongJumpScope to Thread. (Closed)

Created:
5 years, 4 months ago by koda

Modified:
5 years, 4 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Migrate LongJumpScope to Thread. This was one of the blockers for concurrent compilation (issue 24109). BUG= R=srdjan@google.com Committed: https://github.com/dart-lang/sdk/commit/76ff397c1c78463642571d63cc09e299aaf1d3b8

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+68 lines, -53 lines)			Patch
M	runtime/vm/allocation_test.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/dart_entry.cc	View		2 chunks	+8 lines, -8 lines	0 comments	Download
M	runtime/vm/isolate.h	View		4 chunks	+1 line, -5 lines	0 comments	Download
M	runtime/vm/isolate.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/longjump.h	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	runtime/vm/longjump.cc	View		2 chunks	+8 lines, -4 lines	0 comments	Download
M	runtime/vm/longjump_test.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/object.cc	View	1	2 chunks	+7 lines, -3 lines	0 comments	Download
M	runtime/vm/parser.cc	View		4 chunks	+15 lines, -11 lines	0 comments	Download
M	runtime/vm/precompiler.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/report.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/snapshot.cc	View		3 chunks	+11 lines, -10 lines	0 comments	Download
M	runtime/vm/thread.h	View		3 chunks	+7 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

koda

5 years, 4 months ago (2015-08-17 20:29:21 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
76ff397c1c78463642571d63cc09e299aaf1d3b8 (presubmit successful).