Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Issue 12995003: Suppress no_library_test on Dartium, which requires all tests wrapped (Closed)

Created:
7 years, 9 months ago by Alan Knight
Modified:
7 years, 9 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Suppress no_library_test on Dartium, which requires all tests wrapped Committed: https://code.google.com/p/dart/source/detail?r=20350

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M pkg/pkg.status View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Alan Knight
7 years, 9 months ago (2013-03-21 21:05:14 UTC) #1
Alan Knight
TBR
7 years, 9 months ago (2013-03-21 21:05:30 UTC) #2
Alan Knight
Committed patchset #1 manually as r20350 (presubmit successful).
7 years, 9 months ago (2013-03-21 21:05:43 UTC) #3
Emily Fortuna
7 years, 9 months ago (2013-03-21 21:22:03 UTC) #4
Message was sent while issue was closed.
lgtm. I'd recommend commenting that test line as "# Expected failure" just to
make is extra clear that it's not something that needs to be fixed.

Powered by Google App Engine
This is Rietveld 408576698