Make generic type of timeout-future the same as the one from the original.

Make generic type of timeout-future the same as the one from the original.

R=lrn@google.com

Committed: https://github.com/dart-lang/sdk/commit/963f653b12c57c22b4c1252e70bc5468846eb23b

[floitsch, 2015-08-14 18:07:13]

floitsch@google.com changed reviewers:
+ lrn@google.com

[floitsch, 2015-08-14 18:07:14]

It doesn't make sense to have another type there, since the original value is
most likely to flow through.

It's a breaking change in case someone really returns different types when a
timeout occurs.

[floitsch, 2015-08-14 18:32:11]

Note that Stream.firstWhere seems to explicitly allow the "defaultValue"
function to return *anything*.
The signature is
`Future<dynamic> firstWhere(bool test(T element), {Object defaultValue()})`.

Not sure why we went that route.

[floitsch, 2015-08-14 18:33:29]

On 2015/08/14 18:32:11, floitsch wrote:
> Note that Stream.firstWhere seems to explicitly allow the "defaultValue"
> function to return *anything*.
> The signature is
> `Future<dynamic> firstWhere(bool test(T element), {Object defaultValue()})`.
> 
> Not sure why we went that route.

Similarly the Stream.timeout allows arbitrary values when the stream times out.
I would change that one as well...

[Lasse Reichstein Nielsen, 2015-08-14 22:08:35]

https://codereview.chromium.org/1299443002/diff/1/sdk/lib/async/future.dart
File sdk/lib/async/future.dart (right):

https://codereview.chromium.org/1299443002/diff/1/sdk/lib/async/future.dart#n...
sdk/lib/async/future.dart:523: * returns or throws) is used as the result of the
returned future.
Document that onTimeout must return T or Future<T> then.

This is a breaking change if there is existing code with an onTimeout returning
a non-T value.

[floitsch, 2016-02-09 16:30:26]

This CL apparently slipped through the cracks.

https://codereview.chromium.org/1299443002/diff/1/sdk/lib/async/future.dart
File sdk/lib/async/future.dart (right):

https://codereview.chromium.org/1299443002/diff/1/sdk/lib/async/future.dart#n...
sdk/lib/async/future.dart:523: * returns or throws) is used as the result of the
returned future.
On 2015/08/14 22:08:35, Lasse Reichstein Nielsen wrote:
> Document that onTimeout must return T or Future<T> then.
> 
> This is a breaking change if there is existing code with an onTimeout
returning
> a non-T value.

I agree, but it seems very unlikely.

[Lasse Reichstein Nielsen, 2016-02-09 16:37:05]

lgtm

https://codereview.chromium.org/1299443002/diff/20001/sdk/lib/async/future.dart
File sdk/lib/async/future.dart (right):

https://codereview.chromium.org/1299443002/diff/20001/sdk/lib/async/future.da...
sdk/lib/async/future.dart:524: * The result of the [onTimeout] function must
return a [T] or a `Future<T>`.
either "the [onTimeout] function must return"
or "the result of the [onTimeout] function must be"

[floitsch, 2016-02-09 17:04:21]

https://codereview.chromium.org/1299443002/diff/20001/sdk/lib/async/future.dart
File sdk/lib/async/future.dart (right):

https://codereview.chromium.org/1299443002/diff/20001/sdk/lib/async/future.da...
sdk/lib/async/future.dart:524: * The result of the [onTimeout] function must
return a [T] or a `Future<T>`.
On 2016/02/09 16:37:05, Lasse Reichstein Nielsen wrote:
> either "the [onTimeout] function must return"
> or "the result of the [onTimeout] function must be"

Done.

[floitsch, 2016-02-09 17:57:30]

Description was changed from

==========
Make generic type of timeout-future the same as the one from the original.
==========

to

==========
Make generic type of timeout-future the same as the one from the original.

R=lrn@google.com

Committed:
https://github.com/dart-lang/sdk/commit/963f653b12c57c22b4c1252e70bc5468846eb23b
==========

[floitsch, 2016-02-09 17:57:32]

Committed patchset #3 (id:40001) manually as
963f653b12c57c22b4c1252e70bc5468846eb23b (presubmit successful).