Issue 1299393002: dart2js: Just because it's slow doesn't mean it has to be dumb.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1299393002: dart2js: Just because it's slow doesn't mean it has to be dumb. (Closed)

Created:
5 years, 4 months ago by Kevin Millikin (Google)

Modified:
5 years, 4 months ago

Reviewers:
asgerf

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

dart2js: Just because it's slow doesn't mean it has to be dumb. Change LinkEntry.slowLength to be iterative instead of recursive. The Guassian blur benchmark, ported from the Kraken JS benchmark suite, has a 427,200 element list literal. Computing the length of a linked list of 427,200 entries will be a stack overflow. R=asgerf@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/1ed82e83c8a386ca167f038ce2a37a4451622b1c

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -8 lines)			Patch
	M	pkg/compiler/lib/src/util/link.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	pkg/compiler/lib/src/util/link_implementation.dart	View		7 chunks	+15 lines, -8 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Google)

5 years, 4 months ago (2015-08-20 09:02:05 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
1ed82e83c8a386ca167f038ce2a37a4451622b1c (presubmit successful).

Expand Messages | Collapse Messages