Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 1299283002: Unnamed libraries do not cause warnings. Also minor correction wrt privacy. (Closed)

Created:
5 years, 4 months ago by gbracha
Modified:
5 years, 4 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : No warnings on exports either. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M docs/language/dartLangSpec.tex View 1 4 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
gbracha
5 years, 4 months ago (2015-08-19 17:36:36 UTC) #2
Brian Wilkerson
LGTM unless the export case also needs to be updated. https://codereview.chromium.org/1299283002/diff/1/docs/language/dartLangSpec.tex File docs/language/dartLangSpec.tex (right): https://codereview.chromium.org/1299283002/diff/1/docs/language/dartLangSpec.tex#newcode6792 ...
5 years, 4 months ago (2015-08-19 17:51:00 UTC) #3
gbracha
On 2015/08/19 17:51:00, Brian Wilkerson wrote: > LGTM unless the export case also needs to ...
5 years, 4 months ago (2015-08-19 19:09:19 UTC) #4
gbracha
5 years, 4 months ago (2015-08-19 19:09:31 UTC) #5
Brian Wilkerson
LGTM! Thanks!
5 years, 4 months ago (2015-08-19 20:15:00 UTC) #6
gbracha
5 years, 4 months ago (2015-08-19 20:21:42 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
a0e4f281609de0e4c66676c299f630d570e9e276 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698