Issue 1299083002: Automagically change the meaning of 'next' to 'async-next' when paused at an async function at awai…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1299083002: Automagically change the meaning of 'next' to 'async-next' when paused at an async function at awai… (Closed)

Created:
5 years, 4 months ago by rmacnak

Modified:
5 years, 4 months ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Automagically change the meaning of 'next' to 'async-next' when paused at an async function at await/yield. R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/07b6dad1f5ba5c2dac977b804fd17f73c5986391

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+194 lines, -55 lines)			Patch
M	runtime/observatory/lib/src/elements/debugger.dart	View	1	7 chunks	+86 lines, -52 lines	0 comments	Download
M	runtime/observatory/lib/src/service/object.dart	View	1 2	3 chunks	+5 lines, -1 line	0 comments	Download
A	runtime/observatory/tests/service/smart_next_test.dart	View	1 2	1 chunk	+70 lines, -0 lines	0 comments	Download
M	runtime/observatory/tests/service/test_helper.dart	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/debugger.h	View		3 chunks	+10 lines, -1 line	0 comments	Download
M	runtime/vm/debugger.cc	View		1 chunk	+11 lines, -1 line	0 comments	Download
M	runtime/vm/service_event.h	View		3 chunks	+9 lines, -0 lines	0 comments	Download
M	runtime/vm/service_event.cc	View		2 chunks	+2 lines, -0 lines	0 comments	Download

Total messages: 5 (1 generated)

rmacnak

On 2015/08/18 20:50:23, Cutch wrote: > LGTM with a test Added.

5 years, 4 months ago (2015-08-18 22:27:36 UTC) #4

rmacnak

5 years, 4 months ago (2015-08-18 22:36:20 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
07b6dad1f5ba5c2dac977b804fd17f73c5986391 (presubmit successful).