Issue 1298923004: Repair a dart2js test failure due to unused methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1298923004: Repair a dart2js test failure due to unused methods. (Closed)

Created:
5 years, 4 months ago by Kevin Millikin (Google)

Modified:
5 years, 4 months ago

Reviewers:
Johnni Winther

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Repair a dart2js test failure due to unused methods. A recent change made three useful utility functions become unused in dart2js. Add them to the whitelist of unused functions, because we are likely to use them again in a future change. BUG= R=johnniwinther@google.com Committed: https://github.com/dart-lang/sdk/commit/7b3141f7e72e2b5150eb412742cb5b217416e331

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -1 line)			Patch
	M	tests/compiler/dart2js/analyze_unused_dart2js_test.dart	View		1 chunk	+8 lines, -1 line	0 comments	Download

Total messages: 4 (1 generated)

Kevin Millikin (Google)

We could also just remove these functions. I have a feeling we will either use ...

5 years, 4 months ago (2015-08-19 07:10:29 UTC) #2

Kevin Millikin (Google)

5 years, 4 months ago (2015-08-19 07:17:17 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
7b3141f7e72e2b5150eb412742cb5b217416e331 (presubmit successful).