Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 1298553002: dart2js: switch to use dart2js_info/info.dart (Closed)

Created:
5 years, 4 months ago by Siggi Cherem (dart-lang)
Modified:
5 years, 4 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 : #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1569 lines) Patch
M DEPS View 1 2 chunks +3 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/dump_info.dart View 2 chunks +2 lines, -1 line 0 comments Download
D pkg/compiler/lib/src/info/info.dart View 1 chunk +0 lines, -745 lines 0 comments Download
M pkg/compiler/pubspec.yaml View 1 1 chunk +2 lines, -5 lines 0 comments Download
D pkg/compiler/tool/code_deps.dart View 1 chunk +0 lines, -105 lines 0 comments Download
D pkg/compiler/tool/coverage_log_server.dart View 1 chunk +0 lines, -190 lines 0 comments Download
D pkg/compiler/tool/graph.dart View 1 chunk +0 lines, -292 lines 0 comments Download
D pkg/compiler/tool/library_size_split.dart View 1 chunk +0 lines, -132 lines 0 comments Download
D pkg/compiler/tool/util.dart View 1 chunk +0 lines, -96 lines 0 comments Download
M tests/compiler/dart2js/analyze_unused_dart2js_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Siggi Cherem (dart-lang)
5 years, 4 months ago (2015-08-15 02:14:44 UTC) #4
Harry Terkelsen
lgtm
5 years, 4 months ago (2015-08-18 01:10:55 UTC) #5
Bill Hesse
https://codereview.chromium.org/1298553002/diff/40001/DEPS File DEPS (right): https://codereview.chromium.org/1298553002/diff/40001/DEPS#newcode200 DEPS:200: # TODO(sigmund): replace url once we have the github_mirror ...
5 years, 4 months ago (2015-08-18 07:53:32 UTC) #7
Siggi Cherem (dart-lang)
Thanks Bill, Indeed - i believe I need to add it in the dartium DEPS ...
5 years, 4 months ago (2015-08-18 22:37:51 UTC) #8
Siggi Cherem (dart-lang)
Committed patchset #2 (id:60001) manually as 8896ccd3857222368ad890c04a0a0c01a77067ea (presubmit successful).
5 years, 4 months ago (2015-08-18 22:44:45 UTC) #9
Bill Hesse
5 years, 4 months ago (2015-08-19 08:20:11 UTC) #10
Message was sent while issue was closed.
On 2015/08/18 22:37:51, Siggi Cherem (dart-lang) wrote:
> Thanks Bill,
> 
> Indeed - i believe I need to add it in the dartium DEPS too. Any reason why
all
> the deps there use github directly and not our mirror?

No, I noticed that too, and they should be switched to the mirror.

Powered by Google App Engine
This is Rietveld 408576698