Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12982010: Review changes (Closed)

Created:
7 years, 9 months ago by Cutch
Modified:
7 years, 9 months ago
Reviewers:
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Merged #

Unified diffs Side-by-side diffs Delta from patch set Stats (+733 lines, -1611 lines) Patch
M runtime/lib/byte_array.cc View 3 chunks +0 lines, -55 lines 0 comments Download
M runtime/lib/byte_array.dart View 2 chunks +0 lines, -11 lines 0 comments Download
M runtime/lib/scalarlist_sources.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
D runtime/lib/simd128.dart View 1 chunk +0 lines, -782 lines 0 comments Download
M runtime/lib/typeddata.cc View 2 chunks +1 line, -1 line 0 comments Download
M runtime/lib/typeddata.dart View 6 chunks +374 lines, -0 lines 0 comments Download
M runtime/lib/typeddata_sources.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/bootstrap_natives.h View 7 chunks +61 lines, -65 lines 0 comments Download
M runtime/vm/constants_ia32.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/constants_x64.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/intrinsifier.h View 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/vm/intrinsifier_ia32.cc View 3 chunks +12 lines, -2 lines 0 comments Download
M runtime/vm/intrinsifier_x64.cc View 3 chunks +12 lines, -2 lines 0 comments Download
M runtime/vm/object.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/vm/object.cc View 1 5 chunks +27 lines, -16 lines 0 comments Download
M runtime/vm/raw_object.h View 1 4 chunks +14 lines, -9 lines 0 comments Download
M runtime/vm/snapshot.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/symbols.h View 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/lib/typeddata_patch.dart View 1 chunk +32 lines, -0 lines 0 comments Download
M sdk/lib/scalarlist/byte_arrays.dart View 1 chunk +0 lines, -24 lines 0 comments Download
M sdk/lib/scalarlist/scalarlist.dart View 1 chunk +1 line, -2 lines 0 comments Download
M sdk/lib/scalarlist/scalarlist_sources.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D sdk/lib/scalarlist/simd128.dart View 1 chunk +0 lines, -188 lines 0 comments Download
M sdk/lib/typeddata/typeddata.dart View 1 chunk +185 lines, -0 lines 0 comments Download
M tests/lib/lib.status View 1 chunk +1 line, -5 lines 0 comments Download
D tests/lib/scalarlist/float32x4_list_test.dart View 1 chunk +0 lines, -66 lines 0 comments Download
D tests/lib/scalarlist/float32x4_test.dart View 1 chunk +0 lines, -375 lines 0 comments Download
M tests/lib/typeddata/float32x4_list_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/lib/typeddata/float32x4_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Cutch
7 years, 9 months ago (2013-03-27 14:44:34 UTC) #1
Message was sent while issue was closed. 
Committed patchset #2 manually as r20559 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698