Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 1298173002: dart2js: Mark startRootIsolate as "used" by the backend. (Closed)

Created:
5 years, 4 months ago by asgerf
Modified:
5 years, 4 months ago
Reviewers:
herhut
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js: Mark startRootIsolate as "used" by the backend. This fixes a type inference issue where the empty type was inferred for the parameters to this method. BUG= R=herhut@google.com Committed: https://github.com/dart-lang/sdk/commit/ff74930f67753be476ceecb6f550128a428d6548

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M pkg/compiler/lib/src/js_backend/backend.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/_internal/js_runtime/lib/isolate_helper.dart View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
asgerf
5 years, 4 months ago (2015-08-18 11:19:44 UTC) #2
herhut
lgtm
5 years, 4 months ago (2015-08-18 13:21:01 UTC) #3
asgerf
5 years, 4 months ago (2015-08-18 13:55:59 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ff74930f67753be476ceecb6f550128a428d6548 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698