Issue 129813005: Add an examples getter for all Message objects in Intl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 129813005: Add an examples getter for all Message objects in Intl (Closed)

Created:
6 years, 11 months ago by Alan Knight

Modified:
6 years, 11 months ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add an examples getter for all Message objects in Intl BUG= R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=31697

Patch Set 2 : Clarified comment #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -1 line)			Patch
	M	pkg/intl/lib/src/intl_message.dart	View	1	1 chunk	+9 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

code lgtm. nit on comment. https://codereview.chromium.org/129813005/diff/1/pkg/intl/lib/src/intl_message.dart File pkg/intl/lib/src/intl_message.dart (right): https://codereview.chromium.org/129813005/diff/1/pkg/intl/lib/src/intl_message.dart#newcode65 pkg/intl/lib/src/intl_message.dart:65: * We find the ...

6 years, 11 months ago (2014-01-09 23:10:32 UTC) #2

Alan Knight

https://codereview.chromium.org/129813005/diff/1/pkg/intl/lib/src/intl_message.dart File pkg/intl/lib/src/intl_message.dart (right): https://codereview.chromium.org/129813005/diff/1/pkg/intl/lib/src/intl_message.dart#newcode65 pkg/intl/lib/src/intl_message.dart:65: * We find the examples from the top-level [MainMessage] ...

6 years, 11 months ago (2014-01-10 18:44:28 UTC) #3

Alan Knight

6 years, 11 months ago (2014-01-10 18:45:17 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r31697 (presubmit successful).

Expand Messages | Collapse Messages

Issue 129813005: Add an examples getter for all Message objects in Intl (Closed)

Description

Patch Set 1 #

Patch Set 2 : Clarified comment #

Messages