Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(924)

Issue 129813003: Initial server package layout (Closed)

Created:
6 years, 11 months ago by Brian Wilkerson
Modified:
6 years, 11 months ago
Reviewers:
scheglov, danrubel
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, --1 lines) Patch
A + pkg/analysis_server/LICENSE View 0 chunks +-1 lines, --1 lines 1 comment Download
A pkg/analysis_server/pubspec.yaml View 1 chunk +9 lines, -0 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
Brian Wilkerson
6 years, 11 months ago (2014-01-09 17:53:39 UTC) #1
danrubel
lgtm
6 years, 11 months ago (2014-01-09 18:51:39 UTC) #2
Brian Wilkerson
Committed patchset #1 manually as r31674 (presubmit successful).
6 years, 11 months ago (2014-01-09 19:33:26 UTC) #3
scheglov
6 years, 11 months ago (2014-01-11 18:56:09 UTC) #4
Message was sent while issue was closed.
https://codereview.chromium.org/129813003/diff/1/pkg/analysis_server/LICENSE
File pkg/analysis_server/LICENSE (right):

https://codereview.chromium.org/129813003/diff/1/pkg/analysis_server/LICENSE#...
pkg/analysis_server/LICENSE:1: Copyright 2013, the Dart project authors. All
rights reserved.
2014?

https://codereview.chromium.org/129813003/diff/1/pkg/analysis_server/pubspec....
File pkg/analysis_server/pubspec.yaml (right):

https://codereview.chromium.org/129813003/diff/1/pkg/analysis_server/pubspec....
pkg/analysis_server/pubspec.yaml:9: unittest: any
move unittest to dev_dependencies?

Powered by Google App Engine
This is Rietveld 408576698