Issue 1297973002: - Speculative change for Dartium bots.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1297973002: - Speculative change for Dartium bots. (Closed)

Created:
5 years, 4 months ago by Ivan Posva

Modified:
5 years, 4 months ago

Reviewers:
koda

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

- Speculative change for Dartium bots. BUG= Committed: https://github.com/dart-lang/sdk/commit/1bc0f8265852fb4f1a961ca250ffc5a12873c239

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	runtime/vm/scavenger.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Ivan Posva

Committed patchset #1 (id:1) manually as 1bc0f8265852fb4f1a961ca250ffc5a12873c239 (presubmit successful).

5 years, 4 months ago (2015-08-17 14:02:14 UTC) #4

koda

Context for the record: this is a partial revert of your previous change https://github.com/dart-lang/sdk/commit/236b72be6607fcae338b6add5e34c57551726266

5 years, 4 months ago (2015-08-17 14:12:44 UTC) #5

koda

Made the bot green, so LGTM. But the code needs an explanation of when and ...

5 years, 4 months ago (2015-08-17 15:57:38 UTC) #6

koda

5 years, 4 months ago (2015-08-17 15:58:28 UTC) #7

Message was sent while issue was closed.

On 2015/08/17 15:57:38, koda wrote:
> Made the bot green, so LGTM. But the code needs an explanation of when and why
> this case occurs (if we need to support it).

... and also a unit test.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages