More allocation tracing unit tests

More allocation tracing unit tests

- Context allocation unit test.
- Class allocation unit test.
- Adjust behaviour of RecordAllocation when we haven't exited Dart code and we aren't profiling the VM to match the sampler.

R=iposva@google.com

Committed: https://github.com/dart-lang/sdk/commit/d14e50b9c71b47abf98b07c9f35bb4c57525bad0

[Cutch, 2015-08-14 16:39:40]

johnmccutchan@google.com changed reviewers:
+ iposva@google.com

[Ivan Posva, 2015-08-15 13:16:48]

-Ivan

https://codereview.chromium.org/1297693003/diff/40001/runtime/vm/profiler_tes...
File runtime/vm/profiler_test.cc (right):

https://codereview.chromium.org/1297693003/diff/40001/runtime/vm/profiler_tes...
runtime/vm/profiler_test.cc:805: result = Dart_Invoke(lib, NewString("foo"), 0,
NULL);
You need to trigger a second class allocation here for the test to actually test
that the class allocation was not recorded. Running foo again will not allocate
a new closure class. You can do that by triggering the compilation of a
different signature class in the second invocation.

[Cutch, 2015-08-17 14:05:12]

https://codereview.chromium.org/1297693003/diff/40001/runtime/vm/profiler_tes...
File runtime/vm/profiler_test.cc (right):

https://codereview.chromium.org/1297693003/diff/40001/runtime/vm/profiler_tes...
runtime/vm/profiler_test.cc:805: result = Dart_Invoke(lib, NewString("foo"), 0,
NULL);
On 2015/08/15 13:16:48, Ivan Posva wrote:
> You need to trigger a second class allocation here for the test to actually
test
> that the class allocation was not recorded. Running foo again will not
allocate
> a new closure class. You can do that by triggering the compilation of a
> different signature class in the second invocation.

Done.

[Ivan Posva, 2015-08-20 18:03:18]

LGTM -ip

[Cutch, 2015-08-20 18:10:42]

Committed patchset #4 (id:60001) manually as
d14e50b9c71b47abf98b07c9f35bb4c57525bad0 (presubmit successful).