Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1297663003: Test running compiler on a helper thread with mutator paused. (Closed)

Created:
5 years, 4 months ago by koda
Modified:
5 years, 4 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Test running compiler on a helper thread with mutator paused. This test currently fails on new-space allocation, etc., and is meant to be used as a milestone in TDD towards a fully concurrent optimizing compiler. (This is analogous to https://codereview.chromium.org/1289153002/ which does pass.) BUG= R=srdjan@google.com Committed: https://github.com/dart-lang/sdk/commit/b96076eba48d739ff436a55530622a22a820c734

Patch Set 1 #

Patch Set 2 : Skip test; it's for TDD. #

Patch Set 3 : Added issue number. #

Total comments: 2

Patch Set 4 : indent #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -1 line) Patch
M runtime/tests/vm/vm.status View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/compiler_test.cc View 1 2 3 3 chunks +66 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
koda
5 years, 4 months ago (2015-08-14 21:10:51 UTC) #2
koda
Correct iposva...
5 years, 4 months ago (2015-08-14 22:21:24 UTC) #4
koda
Added tracking issue number. PTAL
5 years, 4 months ago (2015-08-17 17:12:29 UTC) #5
srdjan
lgtm https://codereview.chromium.org/1297663003/diff/40001/runtime/vm/compiler_test.cc File runtime/vm/compiler_test.cc (right): https://codereview.chromium.org/1297663003/diff/40001/runtime/vm/compiler_test.cc#newcode83 runtime/vm/compiler_test.cc:83: bool* done) Better indentation
5 years, 4 months ago (2015-08-17 20:13:48 UTC) #6
koda
https://codereview.chromium.org/1297663003/diff/40001/runtime/vm/compiler_test.cc File runtime/vm/compiler_test.cc (right): https://codereview.chromium.org/1297663003/diff/40001/runtime/vm/compiler_test.cc#newcode83 runtime/vm/compiler_test.cc:83: bool* done) On 2015/08/17 20:13:48, srdjan wrote: > Better ...
5 years, 4 months ago (2015-08-17 20:27:33 UTC) #7
koda
5 years, 4 months ago (2015-08-17 20:28:01 UTC) #8
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
b96076eba48d739ff436a55530622a22a820c734 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698