Issue 1297443002: Improve timeline iterators and tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1297443002: Improve timeline iterators and tests (Closed)

Created:
5 years, 4 months ago by Cutch

Modified:
5 years, 4 months ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Improve timeline iterators and tests - Refactor TimelineEventBlockIterator - Add TimelineAnalysisThreadEventIterator - Add test of TimelineAnalysisThreadEventIterator. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/119e72ded29bb453975787f23264073f3dfb9ce3

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+174 lines, -37 lines)			Patch
M	runtime/vm/timeline.h	View	2 chunks	+10 lines, -5 lines	0 comments	Download
M	runtime/vm/timeline.cc	View	1 chunk	+25 lines, -18 lines	0 comments	Download
M	runtime/vm/timeline_analysis.h	View	2 chunks	+22 lines, -0 lines	0 comments	Download
M	runtime/vm/timeline_analysis.cc	View	3 chunks	+63 lines, -2 lines	0 comments	Download
M	runtime/vm/timeline_test.cc	View	3 chunks	+54 lines, -12 lines	0 comments	Download

Total messages: 4 (1 generated)

Cutch

5 years, 4 months ago (2015-08-13 22:44:08 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
119e72ded29bb453975787f23264073f3dfb9ce3 (presubmit successful).