Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Issue 1296973002: Revert "Don't zone-register async callbacks for every await call in the VM." (Closed)

Created:
5 years, 4 months ago by floitsch
Modified:
5 years, 4 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Don't zone-register async callbacks for every await call in the VM." This reverts commit 4dae43d63727268f2e0cc45d6020246eb49177b8. Committed: https://github.com/dart-lang/sdk/commit/cb4f9fc925c5a92c6cf756751e38296383f66507

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+214 lines, -487 lines) Patch
M runtime/lib/async_patch.dart View 1 chunk +0 lines, -178 lines 0 comments Download
M runtime/lib/core_patch.dart View 2 chunks +132 lines, -0 lines 0 comments Download
M runtime/vm/ast_transformer.cc View 2 chunks +74 lines, -28 lines 0 comments Download
M runtime/vm/parser.cc View 7 chunks +7 lines, -131 lines 0 comments Download
M runtime/vm/symbols.h View 1 chunk +0 lines, -5 lines 0 comments Download
M sdk/lib/async/future_impl.dart View 3 chunks +1 line, -3 lines 0 comments Download
D tests/lib/async/async_await_zones_test.dart View 1 chunk +0 lines, -142 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
floitsch
TBR.
5 years, 4 months ago (2015-08-17 14:43:05 UTC) #2
floitsch
5 years, 4 months ago (2015-08-17 14:43:40 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
cb4f9fc925c5a92c6cf756751e38296383f66507 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698