Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1080)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1296703002: Move test runtime entries out of the master list. (Closed)

Created:
5 years, 4 months ago by rmacnak
Modified:
5 years, 4 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M runtime/vm/native_entry_test.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/vm/runtime_entry.h View 2 chunks +0 lines, -2 lines 0 comments Download
M runtime/vm/runtime_entry_test.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
rmacnak
5 years, 4 months ago (2015-08-14 19:33:10 UTC) #2
Florian Schneider
lgtm https://codereview.chromium.org/1296703002/diff/20001/runtime/vm/stub_code_arm64_test.cc File runtime/vm/stub_code_arm64_test.cc (right): https://codereview.chromium.org/1296703002/diff/20001/runtime/vm/stub_code_arm64_test.cc#newcode23 runtime/vm/stub_code_arm64_test.cc:23: DECLARE_LEAF_RUNTIME_ENTRY(RawObject*, TestLeafSmiAdd, RawObject*, RawObject*) I think native_entry_test.h would ...
5 years, 4 months ago (2015-08-17 07:48:03 UTC) #3
rmacnak
https://codereview.chromium.org/1296703002/diff/20001/runtime/vm/stub_code_arm64_test.cc File runtime/vm/stub_code_arm64_test.cc (right): https://codereview.chromium.org/1296703002/diff/20001/runtime/vm/stub_code_arm64_test.cc#newcode23 runtime/vm/stub_code_arm64_test.cc:23: DECLARE_LEAF_RUNTIME_ENTRY(RawObject*, TestLeafSmiAdd, RawObject*, RawObject*) On 2015/08/17 07:48:03, Florian Schneider ...
5 years, 4 months ago (2015-08-17 18:04:21 UTC) #4
rmacnak
5 years, 4 months ago (2015-08-17 18:05:23 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
9e18a7519d429f87c70bb3b8871c6cc666ee3fa6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698