Accept a computation that returns a Future for Future.delayed.

Accept a computation that returns a Future for Future.delayed.

R=lrn@google.com

Committed: https://github.com/dart-lang/sdk/commit/00aaf1708de8185dc5312e66fda7c2a7d55206be

[floitsch, 2015-08-14 17:32:27]

floitsch@google.com changed reviewers:
+ lrn@google.com

[Lasse Reichstein Nielsen, 2015-08-14 22:05:04]

lgtm

https://codereview.chromium.org/1296623004/diff/20001/tests/lib/async/future_...
File tests/lib/async/future_constructor2_test.dart (right):

https://codereview.chromium.org/1296623004/diff/20001/tests/lib/async/future_...
tests/lib/async/future_constructor2_test.dart:11: Future<int> voidToIntFuture()
{
drop the "void" - just "intFunction". void is only meaningful as a return value.
The absence of a parameter is not the same as a void parameter.

https://codereview.chromium.org/1296623004/diff/20001/tests/lib/async/future_...
tests/lib/async/future_constructor2_test.dart:51: main() {
I'd prefer if main stared with asyncStart() and ended with asyncEnd().

It prevents the annoying case where the first function called manages to call
its asyncEnd before returning.

It won't happen with the current tests, but it's easy to accidentally write one.

[floitsch, 2015-08-17 09:34:30]

https://codereview.chromium.org/1296623004/diff/20001/tests/lib/async/future_...
File tests/lib/async/future_constructor2_test.dart (right):

https://codereview.chromium.org/1296623004/diff/20001/tests/lib/async/future_...
tests/lib/async/future_constructor2_test.dart:11: Future<int> voidToIntFuture()
{
On 2015/08/14 22:05:04, Lasse Reichstein Nielsen wrote:
> drop the "void" - just "intFunction". void is only meaningful as a return
value.
> The absence of a parameter is not the same as a void parameter.

renamed to 'createIntFuture'.

https://codereview.chromium.org/1296623004/diff/20001/tests/lib/async/future_...
tests/lib/async/future_constructor2_test.dart:51: main() {
On 2015/08/14 22:05:04, Lasse Reichstein Nielsen wrote:
> I'd prefer if main stared with asyncStart() and ended with asyncEnd().
> 
> It prevents the annoying case where the first function called manages to call
> its asyncEnd before returning.
> 
> It won't happen with the current tests, but it's easy to accidentally write
one.

Done.

[floitsch, 2015-08-17 09:34:48]

Committed patchset #3 (id:40001) manually as
00aaf1708de8185dc5312e66fda7c2a7d55206be (presubmit successful).