Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 1296403003: Do not generate some temporary String objects while compiling (field names extracted from getter/se… (Closed)

Created:
5 years, 4 months ago by srdjan
Modified:
5 years, 4 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Do not generate some temporary String objects while compiling (field names extracted from getter/setter functions). BUG= R=iposva@google.com Committed: https://github.com/dart-lang/sdk/commit/476d18aca4c878aa0f3ee8e0af2d8c8afde8a911

Patch Set 1 #

Patch Set 2 : a #

Patch Set 3 : a #

Patch Set 4 : k #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M runtime/vm/object.cc View 1 2 3 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
srdjan
5 years, 4 months ago (2015-08-18 00:23:56 UTC) #2
Ivan Posva
LGTM -ip
5 years, 4 months ago (2015-08-18 00:29:59 UTC) #3
srdjan
5 years, 4 months ago (2015-08-18 00:34:53 UTC) #4
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
476d18aca4c878aa0f3ee8e0af2d8c8afde8a911 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698