Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1296353002: Add --timing (Closed)

Created:
5 years, 4 months ago by Cutch
Modified:
5 years, 3 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add --timing - Dump per thread timing information when an isolate shuts down. DeltaBlue(RunTime): 3654.6660583941607 us. Timing for isolate DeltaBlue.dart$main-109078706 (from 2 threads) Thread 0 (f68f8b40): HandleMessage : 2163.455 ms total on stack; 940.038 ms total executing; 2114.231 ms max on stack; 930.085 ms max executing. CompileFunction : 81.020 ms total on stack; 81.020 ms total executing; 7.745 ms max on stack; 7.745 ms max executing. CompileOptimizedFunction : 109.817 ms total on stack; 109.817 ms total executing; 10.443 ms max on stack; 10.443 ms max executing. CollectNewGeneration : 1032.580 ms total on stack; 1032.580 ms total executing; 7.677 ms max on stack; 7.677 ms max executing. Thread 1 (f7419700): InitializeIsolate : 12.121 ms total on stack; 0.418 ms total executing; 12.121 ms max on stack; 0.418 ms max executing. ObjectStore::Init : 0.002 ms total on stack; 0.002 ms total executing; 0.002 ms max on stack; 0.002 ms max executing. Object::Init : 0.268 ms total on stack; 0.268 ms total executing; 0.268 ms max on stack; 0.268 ms max executing. IsolateSnapshotReader : 11.433 ms total on stack; 11.433 ms total executing; 11.433 ms max on stack; 11.433 ms max executing. CompileFunction : 111.849 ms total on stack; 111.849 ms total executing; 10.798 ms max on stack; 10.704 ms max executing. Totals: HandleMessage : 2163.455 ms total on stack; 940.038 ms total executing; 2114.231 ms max on stack; 930.085 ms max executing. CompileFunction : 192.869 ms total on stack; 192.869 ms total executing; 10.798 ms max on stack; 10.704 ms max executing. CompileOptimizedFunction : 109.817 ms total on stack; 109.817 ms total executing; 10.443 ms max on stack; 10.443 ms max executing. CollectNewGeneration : 1032.580 ms total on stack; 1032.580 ms total executing; 7.677 ms max on stack; 7.677 ms max executing. InitializeIsolate : 12.121 ms total on stack; 0.418 ms total executing; 12.121 ms max on stack; 0.418 ms max executing. ObjectStore::Init : 0.002 ms total on stack; 0.002 ms total executing; 0.002 ms max on stack; 0.002 ms max executing. Object::Init : 0.268 ms total on stack; 0.268 ms total executing; 0.268 ms max on stack; 0.268 ms max executing. IsolateSnapshotReader : 11.433 ms total on stack; 11.433 ms total executing; 11.433 ms max on stack; 11.433 ms max executing. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/fe548c4bcd1c788c289c60bf916f3455c844a69d

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+251 lines, -25 lines) Patch
M runtime/vm/dart.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/isolate.h View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/isolate.cc View 1 2 3 4 5 4 chunks +22 lines, -0 lines 0 comments Download
M runtime/vm/os_thread.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/vm/thread.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/thread.cc View 1 2 3 4 2 chunks +9 lines, -0 lines 0 comments Download
M runtime/vm/thread_registry.h View 1 2 3 4 2 chunks +7 lines, -0 lines 0 comments Download
M runtime/vm/thread_registry.cc View 1 2 3 chunks +35 lines, -17 lines 0 comments Download
M runtime/vm/timeline.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/timeline.cc View 1 2 3 4 5 9 chunks +30 lines, -5 lines 0 comments Download
M runtime/vm/timeline_analysis.h View 5 chunks +28 lines, -1 line 0 comments Download
M runtime/vm/timeline_analysis.cc View 1 2 3 4 5 5 chunks +112 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Cutch
5 years, 3 months ago (2015-08-27 14:23:32 UTC) #2
rmacnak
lgtm
5 years, 3 months ago (2015-08-27 20:07:02 UTC) #3
Cutch
5 years, 3 months ago (2015-09-10 16:31:21 UTC) #4
Message was sent while issue was closed.
Committed patchset #7 (id:120001) manually as
fe548c4bcd1c788c289c60bf916f3455c844a69d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698