Issue 12962003: Moved pkg pubspecs to use dev_dependencies where appropriate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12962003: Moved pkg pubspecs to use dev_dependencies where appropriate (Closed)

Created:
7 years, 9 months ago by kevmoo-old

Modified:
7 years, 9 months ago

Reviewers:
Bob Nystrom, dgrove, nweiz

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Moved pkg pubspecs to use dev_dependencies where appropriate BUG=https://code.google.com/p/dart/issues/detail?id=9309 Committed: https://code.google.com/p/dart/source/detail?r=20285

Patch Set 2 : removed sdk...went with any #

Patch Set 3 : missed a couple of anys #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -25 lines)			Patch
M	pkg/analyzer_experimental/pubspec.yaml	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	pkg/args/pubspec.yaml	View	1	1 chunk	+2 lines, -4 lines	0 comments	Download
M	pkg/http/pubspec.yaml	View	1	1 chunk	+2 lines, -3 lines	0 comments	Download
M	pkg/intl/pubspec.yaml	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	pkg/logging/pubspec.yaml	View	1	1 chunk	+3 lines, -4 lines	0 comments	Download
M	pkg/oauth2/pubspec.yaml	View	1	1 chunk	+3 lines, -4 lines	0 comments	Download
M	pkg/serialization/pubspec.yaml	View	1 2	1 chunk	+2 lines, -3 lines	0 comments	Download
M	pkg/unittest/pubspec.yaml	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	pkg/yaml/pubspec.yaml	View	1 2	1 chunk	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kevmoo-old

The pub bot ran cleanly: ./tools/bots/pub.py -n pub-mac-release I know there is some re-write magic ...

7 years, 9 months ago (2013-03-20 18:42:52 UTC) #1

Bob Nystrom

One suggestion but LGTM. https://codereview.chromium.org/12962003/diff/1/pkg/analyzer_experimental/pubspec.yaml File pkg/analyzer_experimental/pubspec.yaml (right): https://codereview.chromium.org/12962003/diff/1/pkg/analyzer_experimental/pubspec.yaml#newcode10 pkg/analyzer_experimental/pubspec.yaml:10: sdk: unittest While you're at ...

7 years, 9 months ago (2013-03-20 19:16:35 UTC) #2