Issue 1296033004: Support older SDKs in analyzer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1296033004: Support older SDKs in analyzer. (Closed)

Created:
5 years, 4 months ago by Paul Berry

Modified:
5 years, 4 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org, keertip

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Support older SDKs in analyzer. In Dart 1.12, the location of the "libraries.dart" file, which analyzer uses to find the contents of the SDK, will be changed. However, 1.12 hasn't been released yet, so we need analyzer to continue supporting the current stable release of the SDK. This change causes analyzer to first look in the new location for "libraries.dart", and failing that, fall back to the old (pre-1.12) location. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/e10be90e7643cdc3ff660c453599840a7feb12ea

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -19 lines)			Patch
	M	pkg/analyzer/lib/src/generated/sdk_io.dart	View		3 chunks	+37 lines, -18 lines	0 comments	Download
	M	pkg/analyzer/pubspec.yaml	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Paul Berry

5 years, 4 months ago (2015-08-18 21:06:54 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
e10be90e7643cdc3ff660c453599840a7feb12ea (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages