Issue 1295973002: Store the RegExp and the string specialization cid in an Array in RawFunction::data_.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1295973002: Store the RegExp and the string specialization cid in an Array in RawFunction::data_. (Closed)

Created:
5 years, 4 months ago by rmacnak

Modified:
5 years, 4 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Store the RegExp and the string specialization cid in an Array in RawFunction::data_. No change in Function size due to alignment round up. R=regis@google.com Committed: https://github.com/dart-lang/sdk/commit/38eb6cbd4ff0567d33714c1ca5664ba0e04df4e9

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -26 lines)			Patch
M	runtime/vm/flow_graph_type_propagator.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/object.h	View	1 chunk	+3 lines, -6 lines	0 comments	Download
M	runtime/vm/object.cc	View	3 chunks	+14 lines, -13 lines	0 comments	Download
M	runtime/vm/raw_object.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/raw_object_snapshot.cc	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	runtime/vm/regexp.cc	View	2 chunks	+2 lines, -3 lines	0 comments	Download

Total messages: 4 (1 generated)

rmacnak

5 years, 4 months ago (2015-08-14 23:01:15 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
38eb6cbd4ff0567d33714c1ca5664ba0e04df4e9 (presubmit successful).