Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 1295843002: The return-value of 'asFuture' isn't necessarily related to the Stream's type. (Closed)

Created:
5 years, 4 months ago by floitsch
Modified:
5 years, 4 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

The return-value of 'asFuture' isn't necessarily related to the Stream's type. R=lrn@google.com Committed: https://github.com/dart-lang/sdk/commit/410b181e13933757e9c6c671b2ec95f2252dade1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M sdk/lib/async/stream_impl.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/stream_subscription_as_future_test.dart View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
floitsch
5 years, 4 months ago (2015-08-14 19:22:05 UTC) #2
Lasse Reichstein Nielsen
lgtm
5 years, 4 months ago (2015-08-14 22:06:43 UTC) #3
floitsch
5 years, 4 months ago (2015-08-17 12:44:36 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
410b181e13933757e9c6c671b2ec95f2252dade1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698