Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1295823003: VM: Cache instructions entry point in RawFunction/RawCode. (Closed)

Created:
5 years, 4 months ago by Florian Schneider
Modified:
5 years, 4 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM: Cache instructions entry point in RawFunction/RawCode. This make calling sequences shorter and faster, at the expense of an extra word in the code object and the instructions object. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/858f1d811a296cea702652608d34f769d32696ae

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -144 lines) Patch
M runtime/vm/gc_marker.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M runtime/vm/intermediate_language_arm64.cc View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/vm/intermediate_language_mips.cc View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/vm/intrinsifier_arm.cc View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/vm/intrinsifier_arm64.cc View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/vm/intrinsifier_ia32.cc View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/vm/intrinsifier_mips.cc View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/vm/intrinsifier_x64.cc View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/vm/object.h View 4 chunks +12 lines, -6 lines 0 comments Download
M runtime/vm/object.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/raw_object.h View 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/vm/stub_code_arm.cc View 9 chunks +9 lines, -23 lines 0 comments Download
M runtime/vm/stub_code_arm64.cc View 9 chunks +9 lines, -26 lines 0 comments Download
M runtime/vm/stub_code_ia32.cc View 9 chunks +9 lines, -22 lines 0 comments Download
M runtime/vm/stub_code_mips.cc View 9 chunks +9 lines, -22 lines 0 comments Download
M runtime/vm/stub_code_x64.cc View 9 chunks +9 lines, -22 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Florian Schneider
5 years, 4 months ago (2015-08-18 14:16:44 UTC) #2
rmacnak
lgtm
5 years, 4 months ago (2015-08-19 01:07:46 UTC) #3
Florian Schneider
5 years, 4 months ago (2015-08-19 08:04:44 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
858f1d811a296cea702652608d34f769d32696ae (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698