Issue 1295803004: add void to dart:developer log

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1295803004: add void to dart:developer log (Closed)

Created:
5 years, 4 months ago by sethladd

Modified:
5 years, 4 months ago

Reviewers:
Lasse Reichstein Nielsen, Cutch

CC:
reviews_dartlang.org, kevmoo

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

add void to dart:developer log BUG= R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/41e670f9136403f1a32f43f46f5d8b4757bac091

Patch Set 1 #

Patch Set 2 : update #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	sdk/lib/developer/developer.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

sethladd

Committed patchset #2 (id:20001) manually as 41e670f9136403f1a32f43f46f5d8b4757bac091 (presubmit successful).

5 years, 4 months ago (2015-08-19 20:01:36 UTC) #4

Lasse Reichstein Nielsen

You should also change the patch file to match (the VM is more lenient than ...

5 years, 4 months ago (2015-08-20 05:39:50 UTC) #6

sethladd

5 years, 4 months ago (2015-08-20 15:55:24 UTC) #7

Message was sent while issue was closed.

Apologies for missing that. Ryan helped fix:

https://github.com/dart-lang/sdk/commit/360b40a59945393d8c2711ddd04814ca9e0fe1f5

https://github.com/dart-lang/sdk/commit/9278cc312b122f29cc351fcfc53f689958465704

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages