Fix dart2js/source_map_pub_build_validity_test.

Fix dart2js/source_map_pub_build_validity_test.

This relied on "pub build" implicitly running "pub get", which it no
longer does.

Fixes #24102

R=whesse@google.com

Committed: https://github.com/dart-lang/sdk/commit/57bf18c3f808df096fc4a3720228e321a0dd7c13

[nweiz, 2015-08-17 20:29:43]

nweiz@google.com changed reviewers:
+ floitsch@google.com

[Bill Hesse, 2015-08-17 20:40:43]

whesse@google.com changed reviewers:
+ whesse@google.com

[Bill Hesse, 2015-08-17 20:40:44]

https://codereview.chromium.org/1295653005/diff/1/tests/compiler/dart2js/sour...
File tests/compiler/dart2js/source_map_pub_build_validity_test.dart (right):

https://codereview.chromium.org/1295653005/diff/1/tests/compiler/dart2js/sour...
tests/compiler/dart2js/source_map_pub_build_validity_test.dart:13: asyncTest(()
=> createTempDir().then((Directory tmpDir) async {
Why not put createTempDir() inside the async function as well, and drop the
.then.  Then all the rest should be in a try block, and the delete temp dir in a
finally.  Or else leave it as a future, and put the delete temp dir in an
onComplete().

[nweiz, 2015-08-17 21:46:46]

Code review changes

[nweiz, 2015-08-17 21:46:51]

https://codereview.chromium.org/1295653005/diff/1/tests/compiler/dart2js/sour...
File tests/compiler/dart2js/source_map_pub_build_validity_test.dart (right):

https://codereview.chromium.org/1295653005/diff/1/tests/compiler/dart2js/sour...
tests/compiler/dart2js/source_map_pub_build_validity_test.dart:13: asyncTest(()
=> createTempDir().then((Directory tmpDir) async {
On 2015/08/17 20:40:44, Bill Hesse wrote:
> Why not put createTempDir() inside the async function as well, and drop the
> .then.  Then all the rest should be in a try block, and the delete temp dir in
a
> finally.  Or else leave it as a future, and put the delete temp dir in an
> onComplete().

Done.

[Bill Hesse, 2015-08-18 08:05:09]

lgtm

https://codereview.chromium.org/1295653005/diff/20001/tests/compiler/dart2js/...
File tests/compiler/dart2js/source_map_pub_build_validity_test.dart (right):

https://codereview.chromium.org/1295653005/diff/20001/tests/compiler/dart2js/...
tests/compiler/dart2js/source_map_pub_build_validity_test.dart:30:
print(getResult.stdout);
Perhaps put these print statements inside the check for exitCode == 0, so they
print only on failure?

[Bill Hesse, 2015-08-18 08:32:20]

Committed patchset #2 (id:20001) manually as
57bf18c3f808df096fc4a3720228e321a0dd7c13 (presubmit successful).

[Bill Hesse, 2015-08-18 09:41:26]

https://codereview.chromium.org/1295653005/diff/20001/tests/compiler/dart2js/...
File tests/compiler/dart2js/source_map_pub_build_validity_test.dart (right):

https://codereview.chromium.org/1295653005/diff/20001/tests/compiler/dart2js/...
tests/compiler/dart2js/source_map_pub_build_validity_test.dart:14: Directory
tmpDir = createTempDir();
This needs to be = await createTempDir();

https://codereview.chromium.org/1295653005/diff/20001/tests/compiler/dart2js/...
tests/compiler/dart2js/source_map_pub_build_validity_test.dart:45: }));
Extra parenthesis.