Issue 1295653003: Make source maps work in the browser.

Issue 1295653003: Make source maps work in the browser. (Closed)

Created:
5 years, 4 months ago by nweiz

Modified:
5 years, 4 months ago

Reviewers:
kevmoo

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/test@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Make source maps work in the browser. The link from the JS file to the map file was wrong, and dart2js was generating bogus URLs anyway. R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/e96cb7863ab0c1073c14a9b329499c20f1cc8232

Patch Set 2 : Code review changes #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -13 lines)			Patch
M	CHANGELOG.md	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	lib/src/runner/browser/compiler_pool.dart	View	1 chunk	+20 lines, -3 lines	0 comments	Download
M	lib/src/runner/browser/server.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
D	lib/src/runner/browser/static/host.dart.js.map	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	pubspec.yaml	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

kevmoo

On question, otherwise LGTM https://codereview.chromium.org/1295653003/diff/1/test/frontend/expect_async_test.dart File test/frontend/expect_async_test.dart (right): https://codereview.chromium.org/1295653003/diff/1/test/frontend/expect_async_test.dart#newcode16 test/frontend/expect_async_test.dart:16: throw 'dang toots'; Qua?

5 years, 4 months ago (2015-08-13 22:44:30 UTC) #2

nweiz

https://codereview.chromium.org/1295653003/diff/1/test/frontend/expect_async_test.dart File test/frontend/expect_async_test.dart (right): https://codereview.chromium.org/1295653003/diff/1/test/frontend/expect_async_test.dart#newcode16 test/frontend/expect_async_test.dart:16: throw 'dang toots'; On 2015/08/13 22:44:30, kevmoo wrote: > ...

5 years, 4 months ago (2015-08-13 22:46:20 UTC) #4

nweiz

5 years, 4 months ago (2015-08-13 22:46:28 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
e96cb7863ab0c1073c14a9b329499c20f1cc8232 (presubmit successful).

Expand Messages | Collapse Messages