Add _sdkext support back to analysis server

Add _sdkext support back to analysis server

BUG=
R=brianwilkerson@google.com, paulberry@google.com

Committed: https://github.com/dart-lang/sdk/commit/67a7aeaf12b718a8564e804bcfd4851f3879559e

[Cutch, 2015-08-13 16:05:05]

johnmccutchan@google.com changed reviewers:
+ brianwilkerson@google.com, paulberry@google.com

[Brian Wilkerson, 2015-08-13 16:16:37]

LGTM, but you should wait for Paul to look at it because he knows better how
futures changes will impact this.

[Paul Berry, 2015-08-13 17:12:07]

lgtm assuming the issues below are addressed.

https://codereview.chromium.org/1295463003/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/context_manager.dart (right):

https://codereview.chromium.org/1295463003/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/context_manager.dart:1382:
<Folder>[resourceProvider.getFolder(uri.toFilePath())];
This will cause unit testing problems because uri.toFilePath() chooses whether
to create a Windows or a Posix file path based on the OS, but in unit tests we
override this sometimes.  Use resourceProvider.pathContext.fromUri(uri) instead.

https://codereview.chromium.org/1295463003/diff/1/pkg/analysis_server/test/co...
File pkg/analysis_server/test/context_manager_test.dart (right):

https://codereview.chromium.org/1295463003/diff/1/pkg/analysis_server/test/co...
pkg/analysis_server/test/context_manager_test.dart:347:
test_sdk_ext_packagespec() async {
This test verifies correct behavior of your changes to PackagesFileDisposition.

It would be nice to also have a test that verifies that the new code in
PackageMapDisposition works, but unfortunately it's hard to write such a test
today because of dartbug.com/23909.  Would you mind adding a TODO comment
referencing bug 23909, so that when I get around to fixing that bug, I'll
remember to write the additional test?

[Cutch, 2015-08-13 19:24:17]

https://codereview.chromium.org/1295463003/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/context_manager.dart (right):

https://codereview.chromium.org/1295463003/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/context_manager.dart:1382:
<Folder>[resourceProvider.getFolder(uri.toFilePath())];
On 2015/08/13 17:12:07, Paul Berry wrote:
> This will cause unit testing problems because uri.toFilePath() chooses whether
> to create a Windows or a Posix file path based on the OS, but in unit tests we
> override this sometimes.  Use resourceProvider.pathContext.fromUri(uri)
instead.

Done.

https://codereview.chromium.org/1295463003/diff/1/pkg/analysis_server/test/co...
File pkg/analysis_server/test/context_manager_test.dart (right):

https://codereview.chromium.org/1295463003/diff/1/pkg/analysis_server/test/co...
pkg/analysis_server/test/context_manager_test.dart:347:
test_sdk_ext_packagespec() async {
On 2015/08/13 17:12:07, Paul Berry wrote:
> This test verifies correct behavior of your changes to
PackagesFileDisposition.
> 
> It would be nice to also have a test that verifies that the new code in
> PackageMapDisposition works, but unfortunately it's hard to write such a test
> today because of dartbug.com/23909.  Would you mind adding a TODO comment
> referencing bug 23909, so that when I get around to fixing that bug, I'll
> remember to write the additional test?

Done.

[Cutch, 2015-08-13 19:24:41]

Committed patchset #1 (id:1) manually as
67a7aeaf12b718a8564e804bcfd4851f3879559e (presubmit successful).