Issue 1295433003: Reduce size of test StackLimitInterrupts to avoid Win timeouts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1295433003: Reduce size of test StackLimitInterrupts to avoid Win timeouts. (Closed)

Created:
5 years, 4 months ago by koda

Modified:
5 years, 4 months ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Reduce size of test StackLimitInterrupts to avoid Win timeouts. TBR=johnmccutchan@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/d9bb318a04dedb500cf4d0e2ddc526a9e0b18d83

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	runtime/vm/isolate_test.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

koda

Committed patchset #1 (id:1) manually as d9bb318a04dedb500cf4d0e2ddc526a9e0b18d83 (presubmit successful).

5 years, 4 months ago (2015-08-13 19:03:19 UTC) #1

Cutch

On 2015/08/13 19:03:19, koda wrote: > Committed patchset #1 (id:1) manually as > d9bb318a04dedb500cf4d0e2ddc526a9e0b18d83 (presubmit ...

5 years, 4 months ago (2015-08-13 19:17:07 UTC) #2

Cutch

5 years, 4 months ago (2015-08-13 19:34:42 UTC) #3

Message was sent while issue was closed.

On 2015/08/13 19:17:07, Cutch wrote:
> On 2015/08/13 19:03:19, koda wrote:
> > Committed patchset #1 (id:1) manually as
> > d9bb318a04dedb500cf4d0e2ddc526a9e0b18d83 (presubmit successful).
> 
> Is this temporary? This feels like a regression.

As discussed offline this test never worked on Windows in the past.

LGTM.

Expand Messages | Collapse Messages