Ensure a class is finalized before attempting any reflective invocation on it.

Ensure a class is finalized before attempting any reflective invocation on it.

Avoids mysterious error that results when finalization that is triggered by the reflective invocation fails to propogate a compile-time error.

BUG=http://dartbug.com/15886
R=regis@google.com, zra@google.com

Committed: https://code.google.com/p/dart/source/detail?r=31638

[regis, 2014-01-08 22:58:16]

LGTM

[zra, 2014-01-08 23:02:53]

lgtm

https://codereview.chromium.org/129513002/diff/1/runtime/lib/mirrors.cc
File runtime/lib/mirrors.cc (right):

https://codereview.chromium.org/129513002/diff/1/runtime/lib/mirrors.cc#newco...
runtime/lib/mirrors.cc:337: ThrowInvokeError(error);
After many other calls to ThrowInvokeError() there is an UNREACHABLE() assert.
Maybe add one for consistency's sake.

[rmacnak, 2014-01-09 00:17:58]

https://codereview.chromium.org/129513002/diff/1/runtime/lib/mirrors.cc
File runtime/lib/mirrors.cc (right):

https://codereview.chromium.org/129513002/diff/1/runtime/lib/mirrors.cc#newco...
runtime/lib/mirrors.cc:337: ThrowInvokeError(error);
On 2014/01/08 23:02:54, zra wrote:
> After many other calls to ThrowInvokeError() there is an UNREACHABLE() assert.
> Maybe add one for consistency's sake.

Done.

[rmacnak, 2014-01-09 00:18:15]

Committed patchset #2 manually as r31638 (presubmit successful).