Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1398)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1295073003: create dartdoc snapshot, add to dart-sdk. Also add resources needed to run dartdoc from the sdk. (Closed)

Created:
5 years, 4 months ago by keertip
Modified:
5 years, 4 months ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org, ricow1, sethladd
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

create dartdoc snapshot, add to dart-sdk. Also add resources needed to run dartdoc from the sdk. BUG= R=whesse@google.com Committed: https://github.com/dart-lang/sdk/commit/3865dd87482bd54b8d33ba36b89d93943f82b3ba

Patch Set 1 #

Total comments: 3

Patch Set 2 : remove not needed makedirs #

Patch Set 3 : update dartdoc in DEPS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -14 lines) Patch
M DEPS View 1 2 1 chunk +1 line, -1 line 0 comments Download
M create_sdk.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
A + sdk/bin/dartdoc View 1 chunk +2 lines, -2 lines 0 comments Download
A + sdk/bin/dartdoc.bat View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/create_sdk.py View 1 4 chunks +24 lines, -2 lines 0 comments Download
A + utils/dartdoc/dartdoc.gyp View 2 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
keertip
5 years, 4 months ago (2015-08-18 19:58:14 UTC) #2
Bill Hesse
lgtm https://codereview.chromium.org/1295073003/diff/1/tools/create_sdk.py File tools/create_sdk.py (right): https://codereview.chromium.org/1295073003/diff/1/tools/create_sdk.py#newcode138 tools/create_sdk.py:138: os.makedirs(RESOURCE_DIR) This first makedirs is redundant, because makedirs ...
5 years, 4 months ago (2015-08-18 22:15:21 UTC) #3
keertip
https://codereview.chromium.org/1295073003/diff/1/tools/create_sdk.py File tools/create_sdk.py (right): https://codereview.chromium.org/1295073003/diff/1/tools/create_sdk.py#newcode142 tools/create_sdk.py:142: copytree(join(home, 'third_party', 'pkg', 'dartdoc', 'lib', 'templates'), On 2015/08/18 22:15:21, ...
5 years, 4 months ago (2015-08-18 22:34:36 UTC) #4
Bill Hesse
Still lgtm
5 years, 4 months ago (2015-08-19 08:16:42 UTC) #5
keertip
5 years, 4 months ago (2015-08-19 15:02:57 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
3865dd87482bd54b8d33ba36b89d93943f82b3ba (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698