Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1294803003: Implement new parameters on Isolate.spawn() for dart2js. (Closed)

Created:
5 years, 4 months ago by Lasse Reichstein Nielsen
Modified:
5 years, 4 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Siggi Cherem (dart-lang)
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Implement new parameters on Isolate.spawn() for dart2js. R=sgjesse@google.com Committed: https://github.com/dart-lang/sdk/commit/f8f06d784ad1c9e67cbdb5e25eb08d0c62ca8d8c

Patch Set 1 #

Total comments: 3

Patch Set 2 : Make tests succeed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -10 lines) Patch
M sdk/lib/_internal/js_runtime/lib/isolate_helper.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/_internal/js_runtime/lib/isolate_patch.dart View 1 2 chunks +29 lines, -5 lines 0 comments Download
M tests/isolate/exit_at_spawn_test.dart View 1 1 chunk +23 lines, -2 lines 0 comments Download
M tests/isolate/isolate.status View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Lasse Reichstein Nielsen
5 years, 4 months ago (2015-08-18 09:13:40 UTC) #2
Søren Gjesse
Tests? https://codereview.chromium.org/1294803003/diff/1/sdk/lib/_internal/js_runtime/lib/isolate_patch.dart File sdk/lib/_internal/js_runtime/lib/isolate_patch.dart (right): https://codereview.chromium.org/1294803003/diff/1/sdk/lib/_internal/js_runtime/lib/isolate_patch.dart#newcode32 sdk/lib/_internal/js_runtime/lib/isolate_patch.dart:32: return IsolateNatives.spawnFunction(entryPoint, message, paused) Please use forcePause here.
5 years, 4 months ago (2015-08-18 09:15:45 UTC) #3
Siggi Cherem (dart-lang)
Thanks Lasse https://codereview.chromium.org/1294803003/diff/1/sdk/lib/_internal/js_runtime/lib/isolate_patch.dart File sdk/lib/_internal/js_runtime/lib/isolate_patch.dart (right): https://codereview.chromium.org/1294803003/diff/1/sdk/lib/_internal/js_runtime/lib/isolate_patch.dart#newcode32 sdk/lib/_internal/js_runtime/lib/isolate_patch.dart:32: return IsolateNatives.spawnFunction(entryPoint, message, paused) also - add ...
5 years, 4 months ago (2015-08-18 19:21:23 UTC) #5
Lasse Reichstein Nielsen
PTAL https://codereview.chromium.org/1294803003/diff/1/sdk/lib/_internal/js_runtime/lib/isolate_patch.dart File sdk/lib/_internal/js_runtime/lib/isolate_patch.dart (right): https://codereview.chromium.org/1294803003/diff/1/sdk/lib/_internal/js_runtime/lib/isolate_patch.dart#newcode32 sdk/lib/_internal/js_runtime/lib/isolate_patch.dart:32: return IsolateNatives.spawnFunction(entryPoint, message, paused) Will do. I'm not ...
5 years, 4 months ago (2015-08-19 11:13:27 UTC) #6
Søren Gjesse
lgtm
5 years, 4 months ago (2015-08-19 11:43:22 UTC) #7
Lasse Reichstein Nielsen
Committed patchset #2 (id:20001) manually as f8f06d784ad1c9e67cbdb5e25eb08d0c62ca8d8c (presubmit successful).
5 years, 4 months ago (2015-08-19 11:52:41 UTC) #8
Siggi Cherem (dart-lang)
5 years, 4 months ago (2015-08-19 15:43:16 UTC) #9
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698