Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 12946006: Mixin tests that check compile time errors (Closed)

Created:
7 years, 9 months ago by hausner
Modified:
7 years, 9 months ago
Reviewers:
gbracha
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Mixin tests that check compile time errors Check that compiler complains with wrong number of type arguments are passed to super type and mixin type. Committed: https://code.google.com/p/dart/source/detail?r=20261

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -1 line) Patch
M tests/language/language.status View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
M tests/language/language_dart2js.status View 1 2 2 chunks +10 lines, -1 line 0 comments Download
A tests/language/mixin_type_parameters_errors_test.dart View 1 2 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
hausner
7 years, 9 months ago (2013-03-19 23:15:39 UTC) #1
gbracha
https://codereview.chromium.org/12946006/diff/1/tests/language/mixin_type_parameters_cterrors_test.dart File tests/language/mixin_type_parameters_cterrors_test.dart (right): https://codereview.chromium.org/12946006/diff/1/tests/language/mixin_type_parameters_cterrors_test.dart#newcode19 tests/language/mixin_type_parameters_cterrors_test.dart:19: a = new A<String, String>(); /// 03: compile-time error ...
7 years, 9 months ago (2013-03-19 23:27:02 UTC) #2
hausner
Thank you. https://codereview.chromium.org/12946006/diff/1/tests/language/mixin_type_parameters_cterrors_test.dart File tests/language/mixin_type_parameters_cterrors_test.dart (right): https://codereview.chromium.org/12946006/diff/1/tests/language/mixin_type_parameters_cterrors_test.dart#newcode19 tests/language/mixin_type_parameters_cterrors_test.dart:19: a = new A<String, String>(); /// 03: ...
7 years, 9 months ago (2013-03-19 23:46:08 UTC) #3
hausner
7 years, 9 months ago (2013-03-19 23:55:27 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r20261 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698