Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(812)

Issue 12946004: Register allocation tweaks: (Closed)

Created:
7 years, 9 months ago by Vyacheslav Egorov (Google)
Modified:
7 years, 9 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Register allocation tweaks: - Improve heuristic detecting interference on the back-edge. Any value live_in for the loop header can introduce interfering moves at the back edge due to control flow resolution connecting split siblings. Apply adjustments based on this heuristic at the latest point when allocating a free register; - Don't allocate a register for constants that have no constrained uses. R=fschneider@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=20374

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -24 lines) Patch
M runtime/vm/flow_graph_allocator.cc View 1 6 chunks +58 lines, -24 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Vyacheslav Egorov (Google)
7 years, 9 months ago (2013-03-19 22:31:21 UTC) #1
Florian Schneider
LGTM. https://codereview.chromium.org/12946004/diff/1/runtime/vm/flow_graph_allocator.cc File runtime/vm/flow_graph_allocator.cc (right): https://codereview.chromium.org/12946004/diff/1/runtime/vm/flow_graph_allocator.cc#newcode860 runtime/vm/flow_graph_allocator.cc:860: // TODO(vegorov) improve allocation when we have enough ...
7 years, 9 months ago (2013-03-21 13:17:06 UTC) #2
Vyacheslav Egorov (Google)
Thanks! Landing. https://codereview.chromium.org/12946004/diff/1/runtime/vm/flow_graph_allocator.cc File runtime/vm/flow_graph_allocator.cc (right): https://codereview.chromium.org/12946004/diff/1/runtime/vm/flow_graph_allocator.cc#newcode860 runtime/vm/flow_graph_allocator.cc:860: // TODO(vegorov) improve allocation when we have ...
7 years, 9 months ago (2013-03-22 11:30:35 UTC) #3
Vyacheslav Egorov (Google)
7 years, 9 months ago (2013-03-22 11:44:48 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r20374 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698