Issue 1294483003: Revert "Make List constructor give better error messages for non-int arguments"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1294483003: Revert "Make List constructor give better error messages for non-int arguments" (Closed)

Created:
5 years, 4 months ago by Lasse Reichstein Nielsen

Modified:
5 years, 4 months ago

Reviewers:

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "Make List constructor give better error messages for non-int arguments" There are VM-only tests that assume exact text of failure. BUG= Committed: https://github.com/dart-lang/sdk/commit/51fa195f1655730ee51033ad3752634439c8bcb1

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+44 lines, -114 lines)			Patch
M	runtime/vm/code_generator.cc	View	1 chunk	+25 lines, -32 lines	0 comments	Download
M	runtime/vm/exceptions.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/exceptions.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	runtime/vm/symbols.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/js_runtime/lib/js_array.dart	View	2 chunks	+2 lines, -10 lines	0 comments	Download
M	sdk/lib/collection/list.dart	View	1 chunk	+1 line, -5 lines	0 comments	Download
M	tests/corelib/corelib.status	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/corelib/growable_list_test.dart	View	4 chunks	+15 lines, -60 lines	0 comments	Download

Total messages: 1 (0 generated)

Lasse Reichstein Nielsen

5 years, 4 months ago (2015-08-14 13:05:21 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
51fa195f1655730ee51033ad3752634439c8bcb1 (presubmit successful).