Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 1294473009: Fix script entry case of SdkExtUriResolver.restoreAbsolute (Closed)

Created:
5 years, 4 months ago by Cutch
Modified:
5 years, 4 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix script entry case of SdkExtUriResolver.restoreAbsolute - Fix entry case of restoreAbsolute. - Add TODO to fix part case R=paulberry@google.com Committed: https://github.com/dart-lang/sdk/commit/aa430494f477dcfa669d7ad4c77827ba91f0d06b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -22 lines) Patch
M pkg/analyzer/lib/source/sdk_ext.dart View 2 chunks +15 lines, -8 lines 0 comments Download
M pkg/analyzer/test/source/sdk_ext_test.dart View 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Cutch
5 years, 4 months ago (2015-08-14 22:17:43 UTC) #2
Paul Berry
lgtm as a first step.
5 years, 4 months ago (2015-08-17 16:01:09 UTC) #3
Cutch
5 years, 4 months ago (2015-08-17 17:01:06 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
aa430494f477dcfa669d7ad4c77827ba91f0d06b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698