Issue 1294353003: Make line_splitter_test not use multi-line strings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1294353003: Make line_splitter_test not use multi-line strings. (Closed)

Created:
5 years, 4 months ago by Lasse Reichstein Nielsen

Modified:
5 years, 4 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org, Alan Knight

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Make line_splitter_test not use multi-line strings. Apparently dart2js and the VM disagrees on which characters are in a multi-line string if the source uses Windows line endings. Fixes issue 23856 BUG= http://dartbug.com/23856 R=sgjesse@google.com Committed: https://github.com/dart-lang/sdk/commit/194c729a2a80714ab56a61c11802479da9cae95d Committed: https://github.com/dart-lang/sdk/commit/1a7ff8578dd66dfe04cc7a731dbfc4b9375ac3b2

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -6 lines)			Patch
	M	tests/lib/lib.status	View	1	1 chunk	+0 lines, -6 lines	0 comments	Download

Total messages: 5 (1 generated)

Lasse Reichstein Nielsen

Committed patchset #1 (id:1) manually as 194c729a2a80714ab56a61c11802479da9cae95d (presubmit successful).

5 years, 4 months ago (2015-08-19 09:27:27 UTC) #4

Lasse Reichstein Nielsen

5 years, 4 months ago (2015-08-19 10:35:32 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
1a7ff8578dd66dfe04cc7a731dbfc4b9375ac3b2 (presubmit successful).