Issue 1294353002: dart2js CPS: Inline list.forEach.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1294353002: dart2js CPS: Inline list.forEach. (Closed)

Created:
5 years, 4 months ago by Kevin Millikin (Google)

Modified:
5 years, 4 months ago

Reviewers:
asgerf

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

dart2js CPS: Inline list.forEach. Instead of building up a CPS term representing the implementation of forEach, use the CPS translation on the code for forEach. R=asgerf@google.com Committed: https://github.com/dart-lang/sdk/commit/0a12c2c3d10595c228aa6fdda091b97c615d3566

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -69 lines)			Patch
M	pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	pkg/compiler/lib/src/cps_ir/type_propagation.dart	View	1	17 chunks	+39 lines, -67 lines	0 comments	Download
M	pkg/compiler/lib/src/js_backend/codegen/task.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (1 generated)

Kevin Millikin (Google)

5 years, 4 months ago (2015-08-18 15:15:34 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
0a12c2c3d10595c228aa6fdda091b97c615d3566 (presubmit successful).