Issue 1294283005: Recognize corelib.identical.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1294283005: Recognize corelib.identical. (Closed)

Created:
5 years, 4 months ago by sra1

Modified:
5 years, 4 months ago

Reviewers:
asgerf

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Recognize corelib.identical. Convert to BuiltinOperator.Identical to enable type based simplifications. Remaining unsimplified BuiltinOperator.Identical applications are still codegen-ed as calls to corelib.identical. About half of the calls to identical() in swarm are improved. R=asgerf@google.com Committed: https://github.com/dart-lang/sdk/commit/24588d9fecb9a6a6798ddc5afd7f995ffad6105f

Patch Set 1 : #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -0 lines)			Patch
	M	pkg/compiler/lib/src/cps_ir/type_propagation.dart	View		3 chunks	+26 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

sra1

5 years, 4 months ago (2015-08-19 23:32:01 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:20001) manually as
24588d9fecb9a6a6798ddc5afd7f995ffad6105f (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages