Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 12942007: Fix drawImage on Firefox and update html.status. (Closed)

Created:
7 years, 9 months ago by Andrei Mouravski
Modified:
7 years, 9 months ago
Reviewers:
blois
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix drawImage on Firefox and update html.status. Added some sample videos, as well as spruced up test suite. Committed: https://code.google.com/p/dart/source/detail?r=20334

Patch Set 1 #

Total comments: 3

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+283 lines, -206 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M tests/html/canvasrenderingcontext2d_test.dart View 10 chunks +268 lines, -207 lines 0 comments Download
M tests/html/html.status View 1 3 chunks +5 lines, -1 line 0 comments Download
A tests/html/small.mp4 View 0 chunks +-1 lines, --1 lines 0 comments Download
A tests/html/small.webm View 0 chunks +-1 lines, --1 lines 0 comments Download
M tools/dom/src/CanvasImageSource.dart View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Andrei Mouravski
7 years, 9 months ago (2013-03-21 03:09:19 UTC) #1
blois
lgtm https://codereview.chromium.org/12942007/diff/1/tests/html/html.status File tests/html/html.status (right): https://codereview.chromium.org/12942007/diff/1/tests/html/html.status#newcode92 tests/html/html.status:92: canvasrenderingcontext2d_test/drawImage_video_element_dataUrl: Fail # IE does not support drawImage ...
7 years, 9 months ago (2013-03-21 16:06:44 UTC) #2
Andrei Mouravski
Thanks! Submitting. https://codereview.chromium.org/12942007/diff/1/tests/html/html.status File tests/html/html.status (right): https://codereview.chromium.org/12942007/diff/1/tests/html/html.status#newcode92 tests/html/html.status:92: canvasrenderingcontext2d_test/drawImage_video_element_dataUrl: Fail # IE does not support ...
7 years, 9 months ago (2013-03-21 17:40:33 UTC) #3
Andrei Mouravski
7 years, 9 months ago (2013-03-21 17:45:48 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r20334 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698