Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 1294103004: Handle C?.m as C.m for Sends (Closed)

Created:
5 years, 4 months ago by Johnni Winther
Modified:
5 years, 4 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Remove unused method #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -65 lines) Patch
M pkg/compiler/lib/src/resolution/members.dart View 1 2 5 chunks +13 lines, -40 lines 0 comments Download
M pkg/compiler/lib/src/resolved_visitor.dart View 1 1 chunk +7 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/semantic_visitor_test_send_data.dart View 1 2 chunks +10 lines, -9 lines 0 comments Download
M tests/language/language_dart2js.status View 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Johnni Winther
5 years, 4 months ago (2015-08-17 14:23:11 UTC) #2
floitsch
LGTM.
5 years, 4 months ago (2015-08-17 14:29:17 UTC) #3
Johnni Winther
5 years, 4 months ago (2015-08-18 09:38:57 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
fb7ea815c8af8f78832fc9a4cd746b9c24e84bb1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698