Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 12941008: Unrevert https://codereview.chromium.org/12722009/ (Closed)

Created:
7 years, 9 months ago by Andrei Mouravski
Modified:
7 years, 9 months ago
Reviewers:
blois
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Fixed the status with individual config. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+287 lines, -208 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M tests/html/canvasrenderingcontext2d_test.dart View 1 2 10 chunks +270 lines, -209 lines 0 comments Download
M tests/html/html.status View 1 2 4 chunks +7 lines, -1 line 0 comments Download
A tests/html/small.mp4 View 0 chunks +-1 lines, --1 lines 0 comments Download
A tests/html/small.webm View 0 chunks +-1 lines, --1 lines 0 comments Download
M tools/dom/src/CanvasImageSource.dart View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Andrei Mouravski
Forgot to make it individual config. This should work now. Also, added safari, since it ...
7 years, 9 months ago (2013-03-21 21:00:33 UTC) #1
blois
lgtm & thx for the diff from original!
7 years, 9 months ago (2013-03-21 21:17:19 UTC) #2
Andrei Mouravski
7 years, 9 months ago (2013-03-21 21:22:55 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r20354 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698