Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1294083002: dart2js cps: Set proper receiver type for intercepted methods. (Closed)

Created:
5 years, 4 months ago by asgerf
Modified:
5 years, 4 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js cps: Set proper receiver type for intercepted methods. BUG= R=kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/64825e695d2c576482bda6b7559a9ea0297c0b6e

Patch Set 1 #

Total comments: 1

Patch Set 2 : Go back to using parameter.hint due to issues with constructor bodies #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -32 lines) Patch
M pkg/compiler/lib/src/cps_ir/type_propagation.dart View 1 3 chunks +16 lines, -32 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
asgerf
https://codereview.chromium.org/1294083002/diff/1/pkg/compiler/lib/src/cps_ir/type_propagation.dart File pkg/compiler/lib/src/cps_ir/type_propagation.dart (left): https://codereview.chromium.org/1294083002/diff/1/pkg/compiler/lib/src/cps_ir/type_propagation.dart#oldcode2312 pkg/compiler/lib/src/cps_ir/type_propagation.dart:2312: setValue(node, nonConstant(type)); This was a leftover from dart2dart where ...
5 years, 4 months ago (2015-08-17 09:44:30 UTC) #2
Kevin Millikin (Google)
LGTM.
5 years, 4 months ago (2015-08-17 10:17:11 UTC) #3
asgerf
5 years, 4 months ago (2015-08-18 09:26:58 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
64825e695d2c576482bda6b7559a9ea0297c0b6e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698