Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issue 12940010: Update function subtyping rules to latest spec (issue 9057). (Closed)

Created:
7 years, 9 months ago by regis
Modified:
7 years, 9 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Update function subtyping rules to latest spec (issue 9057). Update language tests and status files (and filed co19 issue 392). Committed: https://code.google.com/p/dart/source/detail?r=20493

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -14 lines) Patch
M runtime/vm/object.cc View 1 3 chunks +12 lines, -5 lines 0 comments Download
M tests/co19/co19-compiler.status View 1 1 chunk +2 lines, -0 lines 0 comments Download
M tests/co19/co19-dart2dart.status View 1 1 chunk +2 lines, -0 lines 0 comments Download
M tests/co19/co19-dart2js.status View 1 1 chunk +2 lines, -0 lines 0 comments Download
M tests/co19/co19-runtime.status View 1 1 chunk +2 lines, -0 lines 0 comments Download
M tests/language/function_type_alias_test.dart View 1 1 chunk +4 lines, -4 lines 0 comments Download
M tests/language/language_dart2js.status View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/typedef_is_test.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
regis
7 years, 9 months ago (2013-03-25 21:50:01 UTC) #1
hausner
lgtm
7 years, 9 months ago (2013-03-25 21:57:23 UTC) #2
regis
Thanks!
7 years, 9 months ago (2013-03-25 22:14:04 UTC) #3
regis
7 years, 9 months ago (2013-03-25 22:14:24 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r20493 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698