Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 12940007: Workaround issue 8080: (Closed)

Created:
7 years, 9 months ago by Ivan Posva
Modified:
7 years, 9 months ago
Reviewers:
ahe, hausner
CC:
reviews_dartlang.org, ahe
Visibility:
Public.

Description

Workaround issue 8080: - Remove the obsolete print of warnings when running tests. Committed: https://code.google.com/p/dart/source/detail?r=20486

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M tools/testing/dart/test_suite.dart View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Ivan Posva
7 years, 9 months ago (2013-03-25 21:01:51 UTC) #1
hausner
lgtm
7 years, 9 months ago (2013-03-25 21:02:55 UTC) #2
Ivan Posva
Committed patchset #1 manually as r20486 (presubmit successful).
7 years, 9 months ago (2013-03-25 21:06:24 UTC) #3
ahe
I'd appreciate if you could revert this. I cannot remove the deprecated feature as long ...
7 years, 9 months ago (2013-03-25 21:43:46 UTC) #4
Ivan Posva
7 years, 9 months ago (2013-03-25 21:48:09 UTC) #5
Message was sent while issue was closed.
On 2013/03/25 21:43:46, ahe wrote:
> I'd appreciate if you could revert this.
> 
> I cannot remove the deprecated feature as long as it is in use, but the
warning
> should prevent others from starting to use it.
> 
> If this is a really high priority for you, I'd suggest you test against the
four
> co19 tests that are known to still use the feature, and not emit a warning for
> them.

I learned from you a while ago that we should no track issues with warnings on
the backs of our users. If suggest that if you really care about this not being
tracked in the bug, then it would be up to you. The way it is currently nobody
would even notice that an additional warning being printed as we have grown
blind to noise in the test output.

-Ivan

Powered by Google App Engine
This is Rietveld 408576698