Issue 12939007: Land incremental building of the editor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12939007: Land incremental building of the editor (Closed)

Created:
7 years, 9 months ago by ricow1

Modified:
7 years, 9 months ago

Reviewers:
kustermann

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Land incremental building of the editor This includes adding the editor target to the gyp files. Committed: https://code.google.com/p/dart/source/detail?r=20228

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+261 lines, -40 lines)			Patch
M	dart/dart.gyp	View	1 chunk	+38 lines, -0 lines	0 comments	Download
M	dart/editor/build/.gitignore	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	dart/editor/build/generate_sources.py	View	1 chunk	+161 lines, -0 lines	0 comments	Download
A	dart/editor/build/truncate_files.py	View	1 chunk	+16 lines, -0 lines	0 comments	Download
M	dart/tools/create_editor.py	View	8 chunks	+41 lines, -40 lines	0 comments	Download
M	deps/all.deps/DEPS	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

kustermann

Since this is the same patch as https://codereview.chromium.org/12090092/, it lgtm.

7 years, 9 months ago (2013-03-19 18:20:53 UTC) #2

ricow1

7 years, 9 months ago (2013-03-19 18:21:57 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r20228 (presubmit successful).