Implement creation of ByteData objects using the Dart API.

Implement creation of ByteData objects using the Dart API.
Committed: https://code.google.com/p/dart/source/detail?r=20396

[Anton Muhin, 2013-03-21 18:35:02]

lgtm

[vsm, 2013-03-21 18:35:27]

DBC

https://chromiumcodereview.appspot.com/12938010/diff/1/runtime/lib/typeddata....
File runtime/lib/typeddata.dart (right):

https://chromiumcodereview.appspot.com/12938010/diff/1/runtime/lib/typeddata....
runtime/lib/typeddata.dart:234: /* patch */ factory ByteData.transferable(int
length) {
I don't see the transferable constructor declared in typeddata_base.dart.  Are
we really keeping this?

It will have no effect in dart2js (i.e., it will just forward to the primary
constructor), so it's really a question of whether Dartium or the VM still needs
this.

[siva, 2013-03-22 01:42:11]

https://chromiumcodereview.appspot.com/12938010/diff/1/runtime/lib/typeddata....
File runtime/lib/typeddata.dart (right):

https://chromiumcodereview.appspot.com/12938010/diff/1/runtime/lib/typeddata....
runtime/lib/typeddata.dart:234: /* patch */ factory ByteData.transferable(int
length) {
I think Anton at one point wanted a way to create
External typed data objects in dart code so that it would
be easy to transfer them to other isolates in the same VM without copying. Not
sure if that is still applicable.

I didn't include them in the public interface as it was
not clear if it is needed or not. I am happy to remove it from here to and we
can add it back if we see a need.

On 2013/03/21 18:35:27, vsm wrote:
> I don't see the transferable constructor declared in typeddata_base.dart.  Are
> we really keeping this?
> 
> It will have no effect in dart2js (i.e., it will just forward to the primary
> constructor), so it's really a question of whether Dartium or the VM still
needs
> this.

[Mads Ager (google), 2013-03-22 07:28:20]

lgtm

[Mads Ager (google), 2013-03-22 08:29:09]

https://chromiumcodereview.appspot.com/12938010/diff/1/runtime/vm/dart_api_im...
File runtime/vm/dart_api_impl.cc (right):

https://chromiumcodereview.appspot.com/12938010/diff/1/runtime/vm/dart_api_im...
runtime/vm/dart_api_impl.cc:2410: String::Handle(isolate,
OneByteString::New("ByteData"));
Does it make sense to have symbols for these strings instead of allocating new
ones on each invocation?

https://chromiumcodereview.appspot.com/12938010/diff/1/runtime/vm/dart_api_im...
runtime/vm/dart_api_impl.cc:2482: const String& dot_name =
String::Handle(String::New(".view"));
Ditto for this one? Alternatively, should this be OneByteString as above? Do you
want to pass in the isolate to the constructors here as well?

https://chromiumcodereview.appspot.com/12938010/diff/1/runtime/vm/dart_api_im...
File runtime/vm/dart_api_impl_test.cc (right):

https://chromiumcodereview.appspot.com/12938010/diff/1/runtime/vm/dart_api_im...
runtime/vm/dart_api_impl_test.cc:894: // EXPECT_EQ(kByteData,
Dart_GetTypeOfTypedData(byte_data));
Code in comment.

https://chromiumcodereview.appspot.com/12938010/diff/1/runtime/vm/dart_api_im...
runtime/vm/dart_api_impl_test.cc:947: // EXPECT_EQ(kByteData,
Dart_GetTypeOfTypedData(byte_data));
Code in comment.

[siva, 2013-03-22 18:03:03]

https://chromiumcodereview.appspot.com/12938010/diff/1/runtime/vm/dart_api_im...
File runtime/vm/dart_api_impl.cc (right):

https://chromiumcodereview.appspot.com/12938010/diff/1/runtime/vm/dart_api_im...
runtime/vm/dart_api_impl.cc:2410: String::Handle(isolate,
OneByteString::New("ByteData"));
Yes, added "ByteData" and "view" to the symbols list.

On 2013/03/22 08:29:09, Mads Ager wrote:
> Does it make sense to have symbols for these strings instead of allocating new
> ones on each invocation?

https://chromiumcodereview.appspot.com/12938010/diff/1/runtime/vm/dart_api_im...
runtime/vm/dart_api_impl.cc:2482: const String& dot_name =
String::Handle(String::New(".view"));
On 2013/03/22 08:29:09, Mads Ager wrote:
> Ditto for this one? Alternatively, should this be OneByteString as above? Do
you
> want to pass in the isolate to the constructors here as well?

Done.

https://chromiumcodereview.appspot.com/12938010/diff/1/runtime/vm/dart_api_im...
File runtime/vm/dart_api_impl_test.cc (right):

https://chromiumcodereview.appspot.com/12938010/diff/1/runtime/vm/dart_api_im...
runtime/vm/dart_api_impl_test.cc:894: // EXPECT_EQ(kByteData,
Dart_GetTypeOfTypedData(byte_data));
Removed comment.

On 2013/03/22 08:29:09, Mads Ager wrote:
> Code in comment.

https://chromiumcodereview.appspot.com/12938010/diff/1/runtime/vm/dart_api_im...
runtime/vm/dart_api_impl_test.cc:947: // EXPECT_EQ(kByteData,
Dart_GetTypeOfTypedData(byte_data));
Removed comment.

On 2013/03/22 08:29:09, Mads Ager wrote:
> Code in comment.

[siva, 2013-03-22 18:14:46]

Committed patchset #2 manually as r20396 (presubmit successful).